Gambas ONE

bill-lancaster wrote: ↑Monday 11th July 2022 8:26am What is the best way to determine the max or min value in array?
At the moment I'm copying the array to a temporary array, sorting it then using array.max

Dim MinVal, MaxVal As Integer

For Each CurVal As Integer in MyArrayOfNumbers
  MaxVal=Max(CurVal, MaxVal)
  MinVal=Min(CurVal, MinVal)
Next

bill-lancaster wrote: ↑Tuesday 12th July 2022 9:06am Thanks Bruce,
That's a nice idea but MinVal is always zero!
Also, copying the array of values into a temporary array then sorting it strangely sorts the original array.

Code: Select all

Dim MyArrayOfNumbers As Integer[] = [99, 91, 93, 92, 95, 90, 95, 100, 90, 90, 99]
Dim fTemp As Integer[]
fTemp = MyArrayOfNumbers
fTemp.Sort
Print fTemp[0];; MyArrayOfNumbers[0]

"What is the best way to determine the max or min value in array?"

 Dim MinVal As Integer = MyArrayOfNumbers[0]
 Dim MaxVal As Integer
 
For Each CurVal As Integer in MyArrayOfNumbers
  MaxVal=Max(CurVal, MaxVal)
  MinVal=Min(CurVal, MinVal)
Next

bill-lancaster wrote: ↑Tuesday 12th July 2022 10:10am Of course! I spotted my mistake earlier and found that this works:-

Code: Select all

fTemp = MyArrayOfNumbers.Copy(0, MyArrayOfNumbers.Max)
fTemp.Sort()
Print fTemp[0];; fTemp[fTemp.Max]

But your solution using MinVal = MyArrayOfNumbers[0] works fine and as you say, iteration is quicker than .Copy.
Thanks for your help

WOW, i used the profiler and found out your way is actually faster, by quite a lot! LOL

Public Sub MinMaxValue((Array) As Variant[]) As Variant[]

  Dim a As Variant[] = Array.Sort()
  Return [a.First, a.Last]

End